-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify FlagCondition #1713
Simplify FlagCondition #1713
Conversation
Last commit published: 58eb1a52723d5a3c270f32146b25d0e0be51c12e. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1713' // https://github.com/neoforged/NeoForge/pull/1713
url 'https://prmaven.neoforged.net/NeoForge/pr1713'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1713
cd NeoForge-pr1713
curl -L https://prmaven.neoforged.net/NeoForge/pr1713/net/neoforged/neoforge/21.3.53-beta-pr-1713-cleanup-1712/mdk-pr1713.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
@Technici4n, this PR introduces breaking changes. Compatibility checks
|
src/main/java/net/neoforged/neoforge/common/conditions/IConditionBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/conditions/IConditionBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/conditions/FlagCondition.java
Outdated
Show resolved
Hide resolved
tests/src/main/java/net/neoforged/neoforge/debug/data/CustomFeatureFlagsTests.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/conditions/FlagCondition.java
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/conditions/IConditionBuilder.java
Show resolved
Hide resolved
tests/src/main/java/net/neoforged/neoforge/debug/data/CustomFeatureFlagsTests.java
Outdated
Show resolved
Hide resolved
58eb1a5
🚀 This PR has been released as NeoForge version |
Simplification of #1712, coming after the fact since it was merged so quickly. 😉