Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify FlagCondition #1713

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

Technici4n
Copy link
Member

Simplification of #1712, coming after the fact since it was merged so quickly. 😉

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 27, 2024

  • Publish PR to GitHub Packages

Last commit published: 58eb1a52723d5a3c270f32146b25d0e0be51c12e.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1713' // https://github.com/neoforged/NeoForge/pull/1713
        url 'https://prmaven.neoforged.net/NeoForge/pr1713'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1713.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1713
cd NeoForge-pr1713
curl -L https://prmaven.neoforged.net/NeoForge/pr1713/net/neoforged/neoforge/21.3.53-beta-pr-1713-cleanup-1712/mdk-pr1713.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Nov 27, 2024

@Technici4n, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 58eb1a52723d5a3c270f32146b25d0e0be51c12e.

Compatibility checks

neoforge (:neoforge)

  • net/neoforged/neoforge/common/conditions/FlagCondition
    • ❗ API class no longer exists
  • net/neoforged/neoforge/common/conditions/IConditionBuilder
    • isFeatureEnabled(Lnet/minecraft/world/flag/FeatureFlag;)Lnet/neoforged/neoforge/common/conditions/ICondition;: ❗ API method was removed
    • isFeatureEnabled(Lnet/minecraft/world/flag/FeatureFlag;[Lnet/minecraft/world/flag/FeatureFlag;)Lnet/neoforged/neoforge/common/conditions/ICondition;: ❗ API method was removed
    • isFeatureDisabled(Lnet/minecraft/world/flag/FeatureFlag;[Lnet/minecraft/world/flag/FeatureFlag;)Lnet/neoforged/neoforge/common/conditions/ICondition;: ❗ API method was removed
    • isFeatureEnabled(Lnet/minecraft/world/flag/FeatureFlagSet;)Lnet/neoforged/neoforge/common/conditions/ICondition;: ❗ API method was removed
    • isFeatureDisabled(Lnet/minecraft/world/flag/FeatureFlagSet;)Lnet/neoforged/neoforge/common/conditions/ICondition;: ❗ API method was removed
    • isFeatureDisabled(Lnet/minecraft/world/flag/FeatureFlag;)Lnet/neoforged/neoforge/common/conditions/ICondition;: ❗ API method was removed
  • net/neoforged/neoforge/common/NeoForgeMod
    • FEATURE_FLAG_CONDITION:Lnet/neoforged/neoforge/registries/DeferredHolder;: ❗ API field was removed

@ApexModder ApexModder added cleanup Change that isn't an enhancement or a bug fix 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 27, 2024
ApexModder
ApexModder previously approved these changes Nov 27, 2024
@marchermans marchermans merged commit 7730007 into neoforged:1.21.x Nov 28, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.49-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 cleanup Change that isn't an enhancement or a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants